Skip to content

Conversation

@louie-tsai
Copy link
Collaborator

@louie-tsai louie-tsai commented Feb 1, 2025

Description

This PR enables OpenTelemetry Tracing for vllm and tgi on both Xeon and Gaudi by docker compose merge feature.
By default, it is disable and it could be enabled by docker compose an additional compose_telemetry.yaml file.
docker compose -f compose.yaml -f compose.telemetry.yaml up -d
It helps to tracing microservice performance for each request.

image

image

PR#1046 is related to this PR.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

NA

Tests

Manually test on Azure Xeon instance

@github-actions
Copy link

github-actions bot commented Feb 1, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@louie-tsai louie-tsai force-pushed the otlp_enable_chatqna branch 3 times, most recently from d92968e to baeadf9 Compare February 3, 2025 07:11
@eero-t
Copy link
Contributor

eero-t commented Feb 3, 2025

What's the performance / latency impact of enabling this feature; e.g. when serviing 1000 parallel users?

(I.e. should it be disabled by default, with an option for enabling it?)

@louie-tsai louie-tsai force-pushed the otlp_enable_chatqna branch 4 times, most recently from 55380d5 to 498858c Compare February 4, 2025 20:24
…new compose_telemetry.yaml files

Signed-off-by: Louie, Tsai <louie.tsai@intel.com>
Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
@louie-tsai louie-tsai changed the title Enable OpenTelemtry Tracing for ChatQnA on Xeon and Gaudi Enable OpenTelemtry Tracing for ChatQnA on Xeon and Gaudi by docker compose merge feature Feb 7, 2025
@louie-tsai
Copy link
Collaborator Author

louie-tsai commented Feb 7, 2025

@eero-t
Agreed
This feature is disabled by default, and it is enabled by merging an additional yaml file like below command.
docker compose -f compose.yaml -f compose.telemetry.yaml up -d

@louie-tsai louie-tsai requested a review from yinghu5 February 11, 2025 06:38
Copy link
Collaborator

@yinghu5 yinghu5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
@louie-tsai louie-tsai merged commit ad5523b into opea-project:main Feb 11, 2025
13 checks passed
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Mar 4, 2025
…ompose merge feature (opea-project#1488)

Signed-off-by: Louie, Tsai <louie.tsai@intel.com>
Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Mar 4, 2025
…ompose merge feature (opea-project#1488)

Signed-off-by: Louie, Tsai <louie.tsai@intel.com>
Signed-off-by: Tsai, Louie <louie.tsai@intel.com>
Signed-off-by: Chingis Yundunov <YundunovCN@sibedge.com>
letonghan pushed a commit that referenced this pull request Sep 17, 2025
- Enhance dataprep to be able to run in the air gapped environment.

- Add documentionation of how to run dataprep in the air gapped
  environment.

Related to bug #1488.

Signed-off-by: Lianhao Lu <lianhao.lu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants